[4.1] Always write the importer version to .import files #84062
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is it guaranteed to return a non-negative number? Otherwise maybe add a |
|
@AThousandShips Yes, it's guaranteed to be either 0 or 1 (those are the only two numbers the code returns). |
|
This PR is obsolete, as a different approach was used in master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Godot 4.0 and 4.1 already have an importer version system, but the number is just... not written if it's 0. I think we should always write the importer version, so future importers can unambiguously know the importer version.
This was driven by a desire to make the version more explicit for #84034, but this is not required for #84034 to work.