Add save shortcut for text shader editor to prevent it propagating to scene #84064
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…scene when hit ctrl s in the shader editor
YuriSizov
changed the title
|
Not really, that PR changed an existing shortcut, this PR adds a new one. We could add shortcuts to other menu items for consistency. Also, now that ShaderEditor will take priority over scene saving, we should handle built-in shaders properly. Saving one should save the scene. Can be done in another PR probably. |
That is partly done in #84063 , I will take a look if there are any more shortcuts can be added.
Ah yes! That needs some extra work probably in another PR. |
KoBeWi
approved these changes
Oct 28, 2023
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #84039
This is a pr for bug fix, I add other shortcuts in #84063