Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use colored output on CI for Doctest #84100

Merged
merged 1 commit into from
Oct 28, 2023

Conversation

Calinou
Copy link
Member

@Calinou Calinou commented Oct 28, 2023

GitHub Actions output is not considered a TTY, so colored output must be forced.

I noticed this while working on #84045.

Preview

image

GitHub Actions output is not considered a TTY, so colored output
must be forced.
@Calinou Calinou requested a review from a team as a code owner October 28, 2023 07:23
@Calinou Calinou added enhancement topic:buildsystem cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release labels Oct 28, 2023
@Calinou Calinou added this to the 4.x milestone Oct 28, 2023
@akien-mga akien-mga modified the milestones: 4.x, 4.2 Oct 28, 2023
@akien-mga akien-mga merged commit 36ce821 into godotengine:master Oct 28, 2023
15 checks passed
@akien-mga
Copy link
Member

Thanks!

@Calinou Calinou deleted the doctest-ci-force-colors branch October 28, 2023 10:53
@YuriSizov
Copy link
Contributor

Cherry-picked for 4.1.4.

@YuriSizov YuriSizov removed the cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release label Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants