Use platform-specific methods for FileAccess reading and writing #84107
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements platform-specific variants of FileAccess's
get_16
,get_32
,get_64
,store_16
,store_32
, andstore_64
. Also adds MSVC-specific versions ofBSWAPxx
functions.This results in a significant performance gain when reading or writing large amounts of binary data: ~5x faster writing and ~6x faster reading.
Benchmark results for writing data to a file:
Windows x64, build - production
A small project for testing whether the changes work correctly: file_access_test.zip
Progress: