Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent encode_variant doing memcpy from nullptr #84155

Merged
merged 1 commit into from
Oct 30, 2023
Merged

Prevent encode_variant doing memcpy from nullptr #84155

merged 1 commit into from
Oct 30, 2023

Conversation

AThousandShips
Copy link
Member

@AThousandShips AThousandShips commented Oct 29, 2023 •
edited
Loading

memcpy will crash on some platforms if the second argument is nullptr (the cases with String doesn't suffer from this as get_data doesn't return nullptr)

@AThousandShips AThousandShips added bug topic:core crash cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release labels Oct 29, 2023
@AThousandShips AThousandShips added this to the 4.2 milestone Oct 29, 2023
@AThousandShips AThousandShips requested a review from a team as a code owner October 29, 2023 17:11
@AThousandShips
Copy link
Member Author

Following this the other issue on the issue needs to be checked, unsure what exactly causes the error as it threw an error about this from the sanitizer I assume it's twofold

@akien-mga akien-mga merged commit a3e4c4f into godotengine:master Oct 30, 2023
15 checks passed
@akien-mga
Copy link
Member

Thanks!

@AThousandShips AThousandShips deleted the encode_fix branch October 31, 2023 10:02
@AThousandShips
Copy link
Member Author

Thank you!

@YuriSizov YuriSizov removed the cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release label Jan 23, 2024
@YuriSizov
Copy link
Contributor

Cherry-picked for 4.1.4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RandomShaper RandomShaper RandomShaper approved these changes

Assignees
No one assigned
Labels
bug crash topic:core
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.
4 participants
@AThousandShips @akien-mga @YuriSizov @RandomShaper