Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix FastNoiseLite.get_image crashes with bad param #84181

Merged
merged 1 commit into from
Oct 30, 2023
Merged

Fix FastNoiseLite.get_image crashes with bad param #84181

merged 1 commit into from
Oct 30, 2023

Conversation

jsjtxietian
Copy link
Contributor

Fixes #84177

I did some quick search about the similar pattern, looks like there is no other places needs fix like this.

@jsjtxietian jsjtxietian requested a review from a team as a code owner October 30, 2023 09:25
@akien-mga akien-mga added this to the 4.2 milestone Oct 30, 2023
akien-mga
akien-mga approved these changes Oct 30, 2023
View reviewed changes
Copy link
Member

@akien-mga akien-mga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but needs rebasing as you included your CSGShape fix too.

@jsjtxietian
Copy link
Contributor Author

Looks good, but needs rebasing as you included your CSGShape fix too.

Sorry! I forgot to change the base branch!

@jsjtxietian jsjtxietian force-pushed the fix-FastNoiseLite.get_image-crash branch from 8340490 to 2936a46 Compare October 30, 2023 09:44
@akien-mga
Copy link
Member

Seems like you squashed but kept the wrong commit message.

@jsjtxietian
Copy link
Contributor Author

My bad. Silly mistake lol.

@jsjtxietian jsjtxietian force-pushed the fix-FastNoiseLite.get_image-crash branch from 2936a46 to e5be42a Compare October 30, 2023 09:55
@jsjtxietian jsjtxietian force-pushed the fix-FastNoiseLite.get_image-crash branch from e5be42a to ff45c08 Compare October 30, 2023 10:45
@akien-mga akien-mga merged commit 5dc10b5 into godotengine:master Oct 30, 2023
15 checks passed
@akien-mga
Copy link
Member

Thanks!

@jsjtxietian jsjtxietian deleted the fix-FastNoiseLite.get_image-crash branch October 30, 2023 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AThousandShips AThousandShips AThousandShips approved these changes

@clayjohn clayjohn clayjohn approved these changes

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
bug crash topic:core
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.

Executing FastNoiseLite.get_image function crashes Godot
4 participants
@jsjtxietian @akien-mga @clayjohn @AThousandShips