Fix activate_item_by_event infinite recursion crash
#84183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YuriSizov
reviewed
Oct 30, 2023
jsjtxietian
force-pushed
the
fix-activate_item_by_event-crash
branch
from
5e5dcd4
to
cc25336
Compare
jsjtxietian
force-pushed
the
fix-activate_item_by_event-crash
branch
from
cc25336
to
b7eefbe
Compare
YuriSizov
reviewed
Oct 31, 2023
YuriSizov
approved these changes
Oct 31, 2023
jsjtxietian
force-pushed
the
fix-activate_item_by_event-crash
branch
from
b7eefbe
to
137b25c
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #84176
The crash cames from
activate_item_by_eventwill call itself on it's submenu item found by name, but if the submenu's name is., it will enter infinite resursion.I chose to prevent it happen from
add_submenu_item, but there might be other ways I wasn't aware of. Feel free to correct me.