Fix WebXR on desktop emulator by resetting active texture unit #84267
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is such a dumb change, that I'm astonished that it fixes anything :-)
By selectively commenting out code, I found that it was
RasterizerCanvasGLES3::reset_canvas()
that ran when drawing 2D which fixed WebXR. So, I copied everything from that function into the end ofRasterizerSceneGLES3::render_scene()
, and by selectively commenting out those lines, I was able to narrow it down to this one line.It seems super weird that changing the active texture unit fixes anything! It must mean that there's code somewhere else that's doing something with textures without remembering to set the active texture unit first? I looked around a little bit but couldn't identify what it could be.
Fixes #84255