Automatically pick the Android SDK path using environment variables #84285
Conversation
|
@akien-mga @YuriSizov It's not a bug so I'm putting in for 4.3, but it's small enough it could be included for 4.2. Up to you to decide! |
platform/android/export/export.cpp
Outdated
| void register_android_exporter_types() { | ||
| GDREGISTER_VIRTUAL_CLASS(EditorExportPlatformAndroid); | ||
| } | ||
|
|
||
| void register_android_exporter() { | ||
| #ifndef ANDROID_ENABLED | ||
| EDITOR_DEF("export/android/android_sdk_path", ""); | ||
| EDITOR_DEF("export/android/android_sdk_path", getenv("ANDROID_SDK_ROOT")); |
There was a problem hiding this comment.
| EDITOR_DEF("export/android/android_sdk_path", getenv("ANDROID_SDK_ROOT")); | |
| EDITOR_DEF("export/android/android_sdk_path", OS::get_singleton()->get_environment("ANDROID_SDK_ROOT")); |
Also, won't be useful on macOS (without #81266), since editor can't access shell environment (not a big deal, but should be mentioned if it's documented to auto pick it).
There was a problem hiding this comment.
I tested on a mac laptop and it seems to work as expected and picked up the env variable.
There was a problem hiding this comment.
It should work only when running the editor from terminal but not when running as a bundled app.
m4gr3d
force-pushed
the
auto_set_android_sdk_default
branch
from
93a9516
to
f86e611
Compare
|
Thanks! |
YuriSizov
changed the title
|
This has proved useful for the automation of the setup under NixOS (see attachment). If we also had environment variable settings for debug_keystore, export_templates_folder and blender3_path then I could make Godot work at startup (ie connect to all the right directories) without having to patch the source code. flake.zip](https://github.com/godotengine/godot/files/13319882/flake.zip) |
@goatchurchprime Sounds like a good idea! Can you create a proposal for it. |
3.x version