Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Export] Improve app / file version validation. #84296

Merged
merged 1 commit into from
Nov 1, 2023
Merged

[Export] Improve app / file version validation. #84296

merged 1 commit into from
Nov 1, 2023

Conversation

bruvzg
Copy link
Member

@bruvzg bruvzg commented Nov 1, 2023

Fixes #83379

@bruvzg bruvzg added this to the 4.2 milestone Nov 1, 2023
@akien-mga akien-mga requested review from YuriSizov and Calinou and removed request for YuriSizov November 1, 2023 08:54
Calinou
Calinou approved these changes Nov 1, 2023
View reviewed changes
Copy link
Member

@Calinou Calinou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good to me.

@akien-mga akien-mga merged commit 2d64e52 into godotengine:master Nov 1, 2023
15 checks passed
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Calinou Calinou Calinou approved these changes

Assignees
No one assigned
Labels
bug topic:editor topic:export
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.

RCEdit fails on export if no version (FileVersion) is specified
3 participants
@bruvzg @akien-mga @Calinou