Add comment why off-by-one error is hard to fix #84297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
reviewed
Nov 1, 2023
akien-mga
approved these changes
Nov 1, 2023
AThousandShips
approved these changes
Nov 1, 2023
|
Could you squash the commits? See PR workflow for instructions. |
See godotengine#83843 Co-authored-by: Rémi Verschelde <rverschelde@gmail.com>
|
Sorry, thanks, done. Here was me thinking I'd try out GitHub's web interface for this trivial change, and having been led to believe that you could squash upon merging. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #83843.