Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unexpose internal data property of AnimationLibrary #84376

Merged

Conversation

YuriSizov
Copy link
Contributor

Supersedes #82713, see the discussion there.

Underscored properties should not be exposed in the first place, so this was a mistake in either the name or property flags. In either case fixing this breaks compat, and it's safer to assume this was not supposed to be exposed.

@AThousandShips
Copy link
Member

AThousandShips commented Nov 2, 2023

I believe all this changes is:

  • No longer documented
  • Inaccessible through extensions and C# (I think)

I'm not sure if the methods are now exposed in C# (normally a property blocks them) or extension

But it's supposed to be internal anyway so I'd say worth it

Edit: correction, already hidden in extensions as it checks leading _, and doesn't consider this flag, nor does C# I think

@YuriSizov YuriSizov merged commit e5f1cbf into godotengine:master Nov 6, 2023
15 checks passed
@YuriSizov
Copy link
Contributor Author

Thanks for reviews!

@YuriSizov YuriSizov deleted the animation-unexpose-internal-property branch November 6, 2023 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants