r128: Update to include latest fix for intrinsics being incorrect included #84537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…luded. fahickman/r128#15 is needed to build on platforms that define R128_STDC_ONLY
fire
approved these changes
Nov 6, 2023
That's basically what it is, yup! 😄 |
|
If you are porting to console in the next 6 months I think getting this in 4.2 is important. Can you talk to the production team? |
akien-mga
added
the
cherrypick:4.1
|
Thanks! |
YuriSizov
removed
the
cherrypick:4.1
|
Cherry-picked for 4.1.4. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r128 upstream has a fix that is needed in order to compile on certain console platforms (fahickman/r128#15).
I'm not sure there's a great reason to diverge from upstream by only picking up the R128_STDC_ONLY patch and none of the other fixes that upstream has - there aren't that many, and it's probably good to have them. Therefore, this PR updates r128.h to the latest version on upstream master, with all the fixes it has since the last time we updated r128 🙂
Contributed by W4 Games