Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CPUParticles2D tangential force does not match GPUParticles2D #84575

Merged
merged 1 commit into from
Dec 19, 2023
Merged

Fix CPUParticles2D tangential force does not match GPUParticles2D #84575

merged 1 commit into from
Dec 19, 2023

Conversation

rsburke4
Copy link
Contributor

@rsburke4 rsburke4 commented Nov 7, 2023 •
edited by AThousandShips
Loading

@rsburke4 rsburke4 requested a review from a team as a code owner November 7, 2023 13:09
@AThousandShips AThousandShips changed the title Fixed CPUParticle tangential force to match GPUParticle implimentation Change CPUParticles2D tangential force to match GPUParticles2D implimentation Nov 7, 2023
@AThousandShips AThousandShips added this to the 4.x milestone Nov 7, 2023
@rsburke4 rsburke4 mentioned this pull request Nov 7, 2023
Closed
@AThousandShips AThousandShips modified the milestones: 4.x, 4.3 Nov 7, 2023
@AThousandShips AThousandShips changed the title Change CPUParticles2D tangential force to match GPUParticles2D implimentation Change CPUParticles2D tangential force to match GPUParticles2D implementation Nov 7, 2023
@AThousandShips AThousandShips changed the title Change CPUParticles2D tangential force to match GPUParticles2D implementation Fix CPUParticles2D tangential force does not match GPUParticles2D Nov 7, 2023
QbieShay
QbieShay approved these changes Dec 16, 2023
View reviewed changes
Copy link
Contributor

@QbieShay QbieShay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like it now correctly reflects the gpuparticles code

force += length(diff.yx) > 0.0 ? vec3(normalize(diff.yx * vec2(-1.0, 1.0)), 0.0) * tangent_accel_val : vec3(0.0);\n";

@YuriSizov YuriSizov merged commit 5d9dce4 into godotengine:master Dec 19, 2023
15 checks passed
@YuriSizov
Copy link
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QbieShay QbieShay QbieShay approved these changes

Assignees
No one assigned
Labels
bug topic:particles topic:2d
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.

CPUParticles2D tangential accel not behaving as expected
4 participants
@rsburke4 @YuriSizov @QbieShay @AThousandShips