Make AnimationTree reference AnimationPlayer instead of AnimationMixer #84583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YuriSizov
reviewed
Nov 7, 2023
|
What if this value is set before the tree is available? |
YuriSizov
added
the
cherrypick:4.2
timothyqiu
force-pushed
the
path-to-ap
branch
from
e4f13d9
to
2770ae7
Compare
timothyqiu
changed the title
AnimationTree.set_animation_player()
|
To makes things easier, I changed the internal reference from AnimationMixer to AnimationPlayer instead. |
TokageItLab
reviewed
Nov 8, 2023
timothyqiu
force-pushed
the
path-to-ap
branch
from
2770ae7
to
7f63fa4
Compare
YuriSizov
reviewed
Dec 15, 2023
YuriSizov
approved these changes
Dec 15, 2023
timothyqiu
force-pushed
the
path-to-ap
branch
from
7f63fa4
to
7946e84
Compare
|
Thanks! |
YuriSizov
removed
the
cherrypick:4.2
|
Cherry-picked for 4.2.2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #83927
The
animation_playerproperty is set to only allow AnimationPlayer. Butset_animation_player()did not do any checks about it. Internally,AnimationTreeonly checks if it points to anAnimationMixerbefore using the path. So when set to point to theAnimationTreeitself, an infinite loop occurs eventually.It's confirmed on RocketChat that
set_animation_player()should only allowAnimationPlayerinstead ofAnimationMixercurrently.