Correctly set up shortcut context in the shader editor #84614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
approved these changes
Nov 8, 2023
There was a problem hiding this comment.
Tested locally, I confirm this fixes the inability to save a scene while the shader editor is open.
Now it behaves as I would expect it (even if it's subpar UX) where the shortcut depends on the focus context, so Ctrl+S in the shader editor saves the shader, and if you focus another editor (scene tree, viewport, inspector, etc.) it will fall back to the main Save Scene function.
This also fixes an unreported bug where a floating shader editor's Ctrl+S would actually always save the scene instead of the script, which is the opposite of the behavior we want in a floating window where the focus is in the window.
|
Thanks! My bad, I did not know I need to call |
KoBeWi
approved these changes
Nov 8, 2023
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the main bug in #84601 (the discussion should still continue about the usability, but this resolves the bug that gets in the way of saving scenes).