Resolve collisions in reference anchors added for methods #84618
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While the anchors themselves were sufficiently unique, when converted to HTML all underscore characters are replaced. This created collisions between, say,
Object._get
andObject.get
, where the latter would get a generic unique anchor identifier, e.g.id1
.You can test this yourself in the current version of the online documentation: https://docs.godotengine.org/en/stable/classes/class_object.html
Now, this change will break existing links in the online docs, which need to be fixed manually after the class reference is synced. It will also break public-facing links for the affected methods, but will allow us to properly link methods which currently get their anchor ids replaced.
Here's a diff from these changes compared to the base commit:
rst-changes.zip