doc: Clarify that DisplayServer.window_set_*_callback aren't supported on Window nodes
#84669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YuriSizov
reviewed
Nov 9, 2023
…ted on Window nodes
akien-mga
force-pushed
the
doc-displayserver-dont-mess-with-windows
branch
from
5789606
to
354c622
Compare
Riteo
approved these changes
Nov 9, 2023
There was a problem hiding this comment.
This addresses my concern about API compatibility, nice!
Also yeah, the other window_set_*_callback stuff is definitely useful if you know what you're doing. I don't think that it'd be worth removing them, so adding a disclaimer is probably the best approach all things considered.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DisplayServer::window_set_window_event_callback#84638, see that PR for details.