Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the validation logic for the package name #84676

Merged
merged 1 commit into from
Dec 8, 2023
Merged

Update the validation logic for the package name #84676

merged 1 commit into from
Dec 8, 2023

Conversation

m4gr3d
Copy link
Contributor

@m4gr3d m4gr3d commented Nov 9, 2023

  • When using the project name, allow underscore (_) characters
  • Send a warning instead of an error when the project name is modified to fit the package name format

Follow up to #71646

@m4gr3d
Update the validation logic for the package name:
0325568 
- When using the project name, allow underscore (`_`) characters
- Send a warning instead of an error when the project name is modified to fit the package name format
@m4gr3d m4gr3d added bug platform:android topic:export cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release labels Nov 9, 2023
@m4gr3d m4gr3d added this to the 4.3 milestone Nov 9, 2023
@m4gr3d m4gr3d requested a review from a team as a code owner November 9, 2023 18:29
akien-mga
akien-mga approved these changes Nov 9, 2023
View reviewed changes
Copy link
Member

@akien-mga akien-mga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks pretty good to me. I'll try to test it to confirm it works as I'd expect.

@YuriSizov YuriSizov merged commit 62b264e into godotengine:master Dec 8, 2023
15 checks passed
@YuriSizov
Copy link
Contributor

Thanks! May Remi still find some time to test it some day 🙏

@m4gr3d m4gr3d deleted the update_package_name_validation_logic branch December 8, 2023 15:50
@YuriSizov YuriSizov removed the cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release label Jan 24, 2024
@YuriSizov
Copy link
Contributor

Cherry-picked for 4.2.2.

@YuriSizov YuriSizov removed the cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release label Jan 24, 2024
@YuriSizov
Copy link
Contributor

Cherry-picked for 4.1.4.

@m4gr3d m4gr3d mentioned this pull request Jun 23, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
bug platform:android topic:export
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.
3 participants
@m4gr3d @YuriSizov @akien-mga