Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix FogMaterial memory leak #84702

Merged
merged 1 commit into from
Nov 10, 2023

Conversation

bitsawer
Copy link
Member

Fixes the FogMaterial resource/memory leak. FogMaterial::cleanup_shader() was implemented and it releases the shared fog shader resource and memory correctly but the method was just never called from anywhere. This PR adds the missing call.

@bitsawer bitsawer added this to the 4.2 milestone Nov 10, 2023
@bitsawer bitsawer requested a review from a team November 10, 2023 10:24
Copy link
Member

@clayjohn clayjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch

@akien-mga akien-mga merged commit 2b987d1 into godotengine:master Nov 10, 2023
14 checks passed
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FogMaterial leaks memory when used
3 participants