Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing getters to navigation servers #84729

Merged
merged 1 commit into from
Dec 19, 2023
Merged

Add missing getters to navigation servers #84729

merged 1 commit into from
Dec 19, 2023

Conversation

nickyfoo
Copy link
Contributor

@nickyfoo nickyfoo commented Nov 10, 2023 •
edited by AThousandShips
Loading

Closes #84495

Add virtual functions and bind to navigation servers
Implement getters
Add documentation

@nickyfoo nickyfoo requested review from a team as code owners November 10, 2023 21:20
@AThousandShips AThousandShips added this to the 4.x milestone Nov 10, 2023
@nickyfoo nickyfoo force-pushed the add-navigationserver-getters branch 2 times, most recently from eae929e to 08edc34 Compare November 13, 2023 10:10
smix8
smix8 reviewed Nov 13, 2023
View reviewed changes
Copy link
Contributor

@smix8 smix8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

As mentioned now that the ref is gone I would remove the dummy and replace the single use in the obstacle vertices error macro with a normal Vector(). It is just more common this way.

modules/navigation/godot_navigation_server.cpp Outdated Show resolved Hide resolved
modules/navigation/godot_navigation_server_2d.h Outdated Show resolved Hide resolved
modules/navigation/godot_navigation_server.h Outdated Show resolved Hide resolved
smix8
smix8 approved these changes Nov 13, 2023
View reviewed changes
Copy link
Contributor

@smix8 smix8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@smix8 smix8 modified the milestones: 4.x, 4.3 Nov 13, 2023
@YuriSizov YuriSizov changed the title Add getters to navigation servers Add missing getters to navigation servers Dec 18, 2023
@nickyfoo @YuriSizov
Add getters to navigation servers
e7ee672 
Add virtual functions and bind to navigation servers
Implement getters
Add documentation
@YuriSizov
Copy link
Contributor

Rebased on your behalf.

@YuriSizov YuriSizov merged commit dee2604 into godotengine:master Dec 19, 2023
15 checks passed
@YuriSizov
Copy link
Contributor

Thanks, and congrats on your first merged Godot contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smix8 smix8 smix8 approved these changes

@AThousandShips AThousandShips AThousandShips approved these changes

Assignees
No one assigned
Labels
enhancement topic:navigation
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.

NavigationServer API is missing some getter functions
4 participants
@nickyfoo @YuriSizov @smix8 @AThousandShips