-
-
Notifications
You must be signed in to change notification settings - Fork 21.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing getters to navigation servers #84729
Add missing getters to navigation servers #84729
Conversation
eae929e
to
08edc34
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
As mentioned now that the ref is gone I would remove the dummy and replace the single use in the obstacle vertices error macro with a normal Vector(). It is just more common this way.
08edc34
to
00946fd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks.
Add virtual functions and bind to navigation servers Implement getters Add documentation
00946fd
to
e7ee672
Compare
Rebased on your behalf. |
Thanks, and congrats on your first merged Godot contribution! |
Closes #84495
Add virtual functions and bind to navigation servers
Implement getters
Add documentation