Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix VisualShader Texture2DParameter node filter bug #84768

Merged
merged 1 commit into from
Nov 11, 2023
Merged

Fix VisualShader Texture2DParameter node filter bug #84768

merged 1 commit into from
Nov 11, 2023

Conversation

biswas08433
Copy link
Contributor

@biswas08433 biswas08433 commented Nov 11, 2023

This bug was appending 2 colons in the generated code. Fixed it by updating the has_colon variable in the filter section.

Also added the source section comment.

Bugsquad edit:

This bug was appending 2 colons in the generated code.  Fixed it.
@biswas08433 biswas08433 requested a review from a team as a code owner November 11, 2023 20:33
@biswas08433 biswas08433 changed the title Fixes Texture2dParameter node filter bug Fix Texture2dParameter node filter bug Nov 11, 2023
@akien-mga akien-mga added this to the 4.2 milestone Nov 11, 2023
@akien-mga akien-mga changed the title Fix Texture2dParameter node filter bug Fix VisualShader Texture2DParameter node filter bug Nov 11, 2023
@akien-mga akien-mga merged commit 89f2f7f into godotengine:master Nov 11, 2023
15 checks passed
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Texture2dParameter "Repeat" option adds extra colon in the generated shader code
2 participants