Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove EditorFileDialog warning when skipping project directories #84797

Conversation

akien-mga
Copy link
Member

We might need better UX to handle this in EditorFileDialog, showing the directories as greyed out with a tooltip, but for now this silences a warning that users have no control over.

Removes this kind of warning that happens frequently when exporting projects and browsing to find where to export them:

WARNING: Detected another project.godot at /home/akien/tmp/godot/bug/Translation Example. The folder will be ignored.
     at: _should_skip_directory (editor/editor_file_system.cpp:2371)

@KoBeWi
Copy link
Member

KoBeWi commented Nov 12, 2023

This reopens #77050

I think a better solution would be avoiding the warning in EditorFileDialog. It should only appear on the initial scan while the project is being opened.

@akien-mga
Copy link
Member Author

I think warning if you have a project.godot in a subfolder of your edited project's folder is fair. That's not a supported use case and that's something you should fix.

But warning because you're browsing your filesystem outside the project's folder and happen to have other Godot projects somewhere is really annoying.

@KoBeWi
Copy link
Member

KoBeWi commented Nov 12, 2023

if (EditorFileSystem::get_singleton()->first_scan) {
	WARN_PRINT_ONCE(vformat("Detected another project.godot at %s. The folder will be ignored.", p_path));
}

We might need better UX to handle this in EditorFileDialog, showing the
directories as greyed out with a tooltip, but for now this silences a warning
that users have no control over.

We keep the warning only in the initial project scan.
@akien-mga akien-mga force-pushed the silence-warning-about-skipping-dirs-with-godot-project branch from e0674f6 to e03f47c Compare November 12, 2023 18:05
@akien-mga akien-mga changed the title Remove EditorFileSystem warning when skipping project directories Remove EditorFileDialog warning when skipping project directories Nov 12, 2023
@akien-mga akien-mga merged commit 4123f13 into godotengine:master Nov 12, 2023
15 checks passed
@akien-mga akien-mga deleted the silence-warning-about-skipping-dirs-with-godot-project branch November 12, 2023 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants