Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit tests for Camera3D #84826

Merged
merged 1 commit into from
Dec 19, 2023
Merged

Conversation

chocola-mint
Copy link
Contributor

This PR adds unit tests for Camera3D mentioned in #43440. Note that the frustum camera mode is not tested because it is unclear what the correct behavior should be mathematically, and there are already a few long-standing issues around it.

Copy link
Member

@Calinou Calinou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

tests/scene/test_camera_3d.h Show resolved Hide resolved
tests/scene/test_camera_3d.h Outdated Show resolved Hide resolved
Copy link
Member

@AThousandShips AThousandShips left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good otherwise!

@YuriSizov YuriSizov merged commit 921c400 into godotengine:master Dec 19, 2023
15 checks passed
@YuriSizov
Copy link
Contributor

Thanks, and congrats on your first merged Godot contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants