Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix DAP breakpoints being cleared on closed scripts #84898

Merged

Conversation

rsubtil
Copy link
Contributor

@rsubtil rsubtil commented Nov 14, 2023

Fixes #83614

When a breakpoint is set for a closed file, that state was saved but the breakpoint was disabled. This honors the p_enabled setting in order to fix the issue. I'm not sure where there are other scenarios where one could set breakpoints on closed files, so this might impact more than I'm expecting.

@rsubtil rsubtil requested a review from a team as a code owner November 14, 2023 16:59
@AThousandShips AThousandShips added this to the 4.3 milestone Nov 14, 2023
@AThousandShips AThousandShips added cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release labels Nov 14, 2023
Copy link
Member

@Paulb23 Paulb23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@YuriSizov YuriSizov merged commit 5c84817 into godotengine:master Dec 18, 2023
15 checks passed
@YuriSizov
Copy link
Contributor

Thanks!

@rsubtil rsubtil deleted the fix_dap_breakpoints_closed_scripts branch December 18, 2023 18:09
@YuriSizov YuriSizov removed the cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release label Jan 24, 2024
@YuriSizov
Copy link
Contributor

Cherry-picked for 4.2.2.

@YuriSizov YuriSizov removed the cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release label Jan 24, 2024
@YuriSizov
Copy link
Contributor

Cherry-picked for 4.1.4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remote debugging with external editor only works if gdscript files are open in script editor
4 participants