Check that GDExtensionCompatHashes
are valid when generating extension_api.json
#84973
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our CI uses the
extension_api.json
to check that we haven't broken GDExtension binary compatibility by removing a method with a particular hash. We're also usingGDExtensionCompatHashes
to map from some old broken hashes to some new ones.However, there isn't anything presently that checks that these mapped hashes are actually valid, which could hide compatibility breakages until runtime.
This PR attempts to validate the mapped hashes when generating the
extension_api.json
.