Fix uint's suffix is not highlighted in text shader editor #85014
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Chaosus
requested changes
May 1, 2024
jsjtxietian
force-pushed
the
fix-uint-not-highlight
branch
from
e9b2810
to
b851514
Compare
clayjohn
approved these changes
May 3, 2024
|
Thanks! |
Calinou
reviewed
May 6, 2024
| @@ -139,6 +141,8 @@ class CodeHighlighter : public SyntaxHighlighter { | |||
|
|
|||
| void set_member_variable_color(Color p_color); | |||
| Color get_member_variable_color() const; | |||
|
|
|||
| void set_uint_suffix_enabled(bool p_enabled = true); | |||
There was a problem hiding this comment.
I'm curious as to why this setter has a default parameter. We generally don't use default parameters for setter methods by convention.
There was a problem hiding this comment.
I just followed @Chaosus 's suggestion for this, in this case looks like explicit is better
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #75161
GDShaderSyntaxHighlighterusesCodeHighlighterwhich doesn't recognize this suffix syntax, there are other ways to fix this, IMHO add a bool in the base class to distinguish the behaviour is the one introduces least change.