Prevent crash in _nvapi_disable_threaded_optimization when attached to renderdoc
#85121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'd suggest doing the change from #85012 in this commit, so we reduce the PR backlog a bit. |
bruvzg
reviewed
Nov 20, 2023
jsjtxietian
force-pushed
the
return-early-nv
branch
from
8be9e81 to
56afd21
Compare
|
Is it crashing in the |
You are right, the |
update outdated link
jsjtxietian
force-pushed
the
return-early-nv
branch
from
56afd21 to
a3f44cd
Compare
jsjtxietian
changed the title
_nvapi_disable_threaded_optimization to avoid crash after renderdoc attach_nvapi_disable_threaded_optimization when attached to renderdoc
|
lgtmi |
akien-mga
approved these changes
Nov 21, 2023
akien-mga
added
the
cherrypick:4.1
|
Thanks! |
akien-mga
changed the title
_nvapi_disable_threaded_optimization when attached to renderdoc_nvapi_disable_threaded_optimization when attached to renderdoc
|
Cherry-picked for 4.1.4. |
YuriSizov
removed
the
cherrypick:4.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A workaround, should fix #84880 when
nvidia_disable_threaded_optimizationis disabled in project setting ( although the root cause is still not solved ) . And this change should probably be there at the first place, it will sightly increase start up time if the user did not want to disable nv's optimization, it's a double win anyway.cc @EIREXE You might want to take a look.