Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Let scene replacement benefit from certain late pieces of frame logic #85184

Merged
merged 1 commit into from
Nov 22, 2023
Merged

Let scene replacement benefit from certain late pieces of frame logic #85184

merged 1 commit into from
Nov 22, 2023

Conversation

RandomShaper
Copy link
Member

@RandomShaper RandomShaper commented Nov 21, 2023 •
edited by akien-mga
Loading

Fixes #85119.

Bugsquad edit:

@RandomShaper RandomShaper added this to the 4.2 milestone Nov 21, 2023
@RandomShaper RandomShaper requested a review from a team as a code owner November 21, 2023 17:33
clayjohn
clayjohn approved these changes Nov 21, 2023
View reviewed changes
Copy link
Member

@clayjohn clayjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally and can confirm it fixes the reported bug.

I'm not familiar enough with this area to provide a qualified technical review, but the changes make sense to me

@akien-mga akien-mga changed the title Let scene replacemnent benefit from certain late pieces of frame logic Let scene replacement benefit from certain late pieces of frame logic Nov 22, 2023
@akien-mga akien-mga merged commit fafc5c2 into godotengine:master Nov 22, 2023
15 checks passed
@akien-mga
Copy link
Member

Thanks!

@RandomShaper RandomShaper deleted the switch_scene_better branch November 22, 2023 11:21
@akien-mga akien-mga mentioned this pull request Nov 22, 2023
Closed
@bitsawer bitsawer mentioned this pull request Dec 2, 2023
Open
@Lippanon Lippanon mentioned this pull request Dec 6, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clayjohn clayjohn clayjohn approved these changes

Assignees
No one assigned
Labels
bug regression topic:core
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.

GPUParticles3D Spawn Incorrectly When Changing Scenes
3 participants
@RandomShaper @akien-mga @clayjohn