Run Clean in Windows SCsub to clean up debug files

[brno32]

Addresses only the Windows platform in #75570

The original issue mentions it's a problem with the "Clean Solution" button in Visual Studio, but the problem is with the call to scons --clean itself, which Visual Studio is using under the hood.

scons --clean only drops the .exe files from the bin folder, but it leaves everything else that's in there.

I couldn't find a way to get SCons to tell me the list of files in the output directory it made from the build, so deriving it from the program name seemed like the next best thing. I don't think we want to just clear the bin folder as that could delete files from targets other than the one being cleaned.

Bugsquad edit:

• Fixes Build system: cleaning Visual Studio solution does not erase .pdb, .ilk, .lib files #75570

[YuriSizov]

I don't think we want to just clear the bin folder as that could delete files from targets other than the one being cleaned.

This is correct, but I think the implementation with a wildcard still has this problem, because different build configurations would only differ by suffixes. So the wildcard mask can overlap.

I think we could use an explicit list of extensions instead.

[brno32]

This is correct, but I think the implementation with a wildcard still has this problem, because different build configurations would only differ by suffixes. So the wildcard mask can overlap.

I think we could use an explicit list of extensions instead.

fair point. I've modified it to use a list. I'm still using a glob to catch things like bin\godot.windows.editor.dev.x86_64.console.pdb

[brno32]

Well, on second thought that still won't work, as the glob could grab something it's not meant to.

I see the console program is a separate SCons Program so I've opted to instead perform this process for both programs

[brno32]

@YuriSizov would you mind taking another look now that I've refactored the approach?

[YuriSizov]

@YuriSizov would you mind taking another look now that I've refactored the approach?

The approach looks fine to me now. But I'm not fluent in SCons to review the implementation for correctness. So we'll need to wait a bit for someone else to take a look.

[akien-mga]

I don't use Windows frequently so I haven't tested, but the rationale makes sense and the implementation seems ok.

[akien-mga]

Thanks!