Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set some dialogs in the VisualShader editor to be exclusive #85205

Merged
merged 1 commit into from
Nov 22, 2023
Merged

Set some dialogs in the VisualShader editor to be exclusive #85205

merged 1 commit into from
Nov 22, 2023

Conversation

jsjtxietian
Copy link
Contributor

Should fix #83805

@jsjtxietian jsjtxietian requested a review from a team as a code owner November 22, 2023 06:27
@akien-mga akien-mga added this to the 4.3 milestone Nov 22, 2023
@akien-mga akien-mga added the cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release label Nov 22, 2023
@akien-mga
Copy link
Member

akien-mga commented Nov 22, 2023 •
edited
Loading

That should work, but I'm not sure it's the best solution.

I would expect either of those behaviors:

  • Either the popup should be exclusive so it can't lose focus until you close it,
  • Or clicking outside the popup should close it, not just lose focus.

WDYT?

@jsjtxietian
Copy link
Contributor Author

jsjtxietian commented Nov 22, 2023 •
edited
Loading

I think either is ok really, I sightly perfer the first solution as the second one may cause some confusion.

@jsjtxietian jsjtxietian changed the title Make poped up add shader node dialog grab focus when needed Set some window in visual shader editor to be exclusive Nov 22, 2023
@jsjtxietian
Copy link
Contributor Author

I have updated the code, along with some other popup window with the same problem in visual shader editor. Tested on my windows it works fine.

@Chaosus
Copy link
Member

Chaosus commented Nov 22, 2023

Seems to be a good replacement for #84488.

akien-mga
akien-mga approved these changes Nov 22, 2023
View reviewed changes
Copy link
Member

@akien-mga akien-mga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me overall.

@akien-mga akien-mga modified the milestones: 4.3, 4.2 Nov 22, 2023
@akien-mga akien-mga removed the cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release label Nov 22, 2023
@akien-mga akien-mga mentioned this pull request Nov 22, 2023
Closed
@akien-mga akien-mga merged commit a34814b into godotengine:master Nov 22, 2023
15 checks passed
@akien-mga
Copy link
Member

Thanks!

@jsjtxietian jsjtxietian deleted the grab-focus branch November 22, 2023 13:33
@akien-mga akien-mga changed the title Set some window in visual shader editor to be exclusive Set some dialogs in the VisualShader editor to be exclusive Nov 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
bug topic:editor topic:shaders usability
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.

Some times can't add node in visualshader editor
3 participants
@jsjtxietian @akien-mga @Chaosus