Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clear seeked/started flag after seeking/advancing in AnimationPlayer #85221

Merged
merged 1 commit into from
Nov 23, 2023
Merged

Clear seeked/started flag after seeking/advancing in AnimationPlayer #85221

merged 1 commit into from
Nov 23, 2023

Conversation

TokageItLab
Copy link
Member

@TokageItLab TokageItLab commented Nov 22, 2023 •
edited
Loading

play() does not immediately process the animation, but waits for the internal process. The flags are cleared at this time, but if a process is interrupted by seek() or advance() in the meantime, the flags will become broken. Fixed.

@TokageItLab TokageItLab added this to the 4.2 milestone Nov 22, 2023
@TokageItLab TokageItLab requested a review from a team as a code owner November 22, 2023 15:03
@akien-mga akien-mga merged commit 1524972 into godotengine:master Nov 23, 2023
15 checks passed
@akien-mga
Copy link
Member

Thanks!

@TokageItLab TokageItLab mentioned this pull request Nov 25, 2023
Merged
@Lippanon Lippanon mentioned this pull request Dec 1, 2023
Closed
@TokageItLab TokageItLab deleted the clear-seek-flg branch February 14, 2024 05:27
@TokageItLab TokageItLab mentioned this pull request May 14, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
bug regression topic:animation
Projects
None yet
Milestone
4.2
2 participants
@TokageItLab @akien-mga