Revert new scene change algorithm #85298
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| DEV_ASSERT(!current_scene); | ||
|
|
||
| pending_new_scene = new_scene; | ||
| call_deferred(SNAME("_change_scene"), new_scene); |
There was a problem hiding this comment.
Does this have to be a named call?
|
After deeper discussion, the new algorithm also has strengths, so until we can find the best of both worlds, the new one is kept. There are very easy ways to emulate the former and the new one will be perfectly documented. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The more I think about it, the more it seems these changes didn't really improve anything by themselves. Much of the issues were of the kind solved now by #85280.
This reverts commit 8bebabd.
This reverts commit 4354cd8.
Fixes #85251.
Supersedes #85279.