Perform safe copies in AnimatedValuesBackup::get_cache_copy()
#85302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Since these also have no-arg constructors the base type also needs one, are the copy constructors necessary? These types should all be trivial |
akien-mga
reviewed
Nov 24, 2023
akien-mga
changed the title
AnimatedValuesBackup::get_cache_copy()
RandomShaper
force-pushed
the
copy_constr_avb
branch
from
daadcc3
to
fbb931d
Compare
AThousandShips
approved these changes
Nov 24, 2023
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
memcpy()ing those types is potentially catastrophic.For more context, see the discussion here: #85266 (comment)