SCons: Change Environment type hints to SConsEnvironment
#85322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calinou
added
bug
topic:buildsystem
cherrypick:4.2
akien-mga
approved these changes
Feb 14, 2024
akien-mga
changed the title
Environment to SConsEnvironmentEnvironment type hints to SConsEnvironment
Repiteo
force-pushed
the
scons-Environment-to-SConsEnvironment
branch
from
1f8a50a to
633dcf6
Compare
|
Thanks! |
akien-mga
removed
the
cherrypick:4.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an inconsistency in the
detect.pytype checking, as the wrong type was being checked; the actual type passed through the argument isSCons.Script.SConscript.SConsEnvironment, notSCons.Environment. In addition to assigning the proper type, this PR also adds type hints to the files' other arguments that expected anenv, as those uniformly expectSConsEnvironmentas well