Unify parameter names for RendererCanvasCull #85421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
reviewed
Nov 29, 2023
xiongyaohua
force-pushed
the
fix_parameter_names
branch
from
bff7380 to
3fd9f87
Compare
|
This PR needs a rebase. |
xiongyaohua
force-pushed
the
fix_parameter_names
branch
from
3fd9f87 to
795fe74
Compare
done |
|
Thanks! |
akien-mga
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
p_prefix to some parameters for the following internal methods:_render_canvas_item_tree_cull_canvas_item_attach_canvas_item_for_drawAnd remove an unused parameter
p_xformfrom_attach_canvas_item_for_draw