-
-
Notifications
You must be signed in to change notification settings - Fork 21.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent a crash when calling AnimationMixer::restore
with an invalid resource
#85428
Prevent a crash when calling AnimationMixer::restore
with an invalid resource
#85428
Conversation
Is this actually likely to happen when the engine calls this method? This is not a part of the exposed API and users providing invalid input is not necessarily a priority, though the fix is cheap (this method can't even really be called from GDScript as the type isn't exposed or functional from that side) |
I believe it's not that high priority. |
A note for a better commit message: describe what problem is addressed rather than how you address it. The how is already obvious from the change. So the message could be "Prevent a crash when calling |
@AThousandShips it is exposed to gdscript - just look at the issue. I remember that once there was a discussion about the fact that from GDScript you can call private api and the conclusion was that is not possible to fix the problem(at that moment), so nothing was done about it(there is definitely an issue about it somewhere) |
It isn't part of the exposed API, there's a difference, a significant one The method can't be called properly ever as it's not a class that's available to GDScript so all this solves is a crash when using this method incorrectly Worth it but not a part of the exposed API |
8e9ab0f
to
707e262
Compare
707e262
to
937411e
Compare
AnimationMixer::restore
with an invalid resource
Thanks! |
Cherry-picked for 4.2.1. |
Fixes #85340