Expose Node.is_part_of_edited_scene()
#85515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mickeon
reviewed
Feb 25, 2024
| @@ -556,6 +556,12 @@ | |||
| [method request_ready] resets it back to [code]false[/code]. | |||
| </description> | |||
| </method> | |||
| <method name="is_part_of_edited_scene" qualifiers="const"> | |||
There was a problem hiding this comment.
Why is_part_of_edited_scene and not is_inside_edited_scene? I mean, I kind of get why, but it does not quite roll off the tongue.
There was a problem hiding this comment.
idk, IMO this name is fine.
Also the method was changed a bit to include siblings of the scene, so is_inside_edited_scene() would be less accurate.
KoBeWi
force-pushed
the
is_node_part_of_edited_scene_and_being_edited()
branch
from
8d480be
to
0b877a9
Compare
akien-mga
changed the title
is_part_of_edited_scene()Node.is_part_of_edited_scene()
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does 3 things:
SceneTree::is_node_being_edited(). It's function is the same as the newly addedis_part_of_edited_scene(), but it requires a check whether node is inside scene treeis_part_of_edited_scene()is now available outside editor, where it will always returnfalseis_part_of_edited_scene()to scriptingCloses godotengine/godot-proposals#8216
Closes (?) godotengine/godot-proposals#900