Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure slider grabs focus only when it can #85652

Merged
merged 1 commit into from
Dec 19, 2023

Conversation

rsubtil
Copy link
Contributor

@rsubtil rsubtil commented Dec 2, 2023

Fixes #85638

Slider attempts to grab focus when the user scrolls them with the mouse wheel (#38918). This check ensures it only does that when the focus mode allows it to.

@rsubtil rsubtil requested a review from a team as a code owner December 2, 2023 11:08
@AThousandShips AThousandShips added this to the 4.3 milestone Dec 2, 2023
@YuriSizov YuriSizov merged commit 26834d2 into godotengine:master Dec 19, 2023
15 checks passed
@YuriSizov
Copy link
Contributor

Thanks!

@rsubtil rsubtil deleted the bugfix-can_grab_focus branch December 19, 2023 19:59
@YuriSizov YuriSizov added the cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release label Jan 24, 2024
@akien-mga
Copy link
Member

Cherry-picked for 4.2.2.

@akien-mga akien-mga removed the cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release label Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Warning spammed when scrolling sliders of the color picker in the Editor
5 participants