[4.2] Fix crash when using incompatible versions of Godot Jolt #85779
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #85576, #85580 and #85581.
As per the discussion on Rocket Chat, This introduces a somewhat hacky check to see if the GDExtension library being loaded has its filename beginning with
godot_jolt_
and is also targeting acompatibility_minimum
of4.1
, which indicates that it's a version that was never officially supported to work with Godot 4.2.Note that this PR targets the
4.2
branch, since it seemed like this would/should be a temporary hack for 4.2 specifically.Also note that this will technically reject Godot Jolt version 0.9.0 and 0.10.0, despite those technically being (somewhat) compatible with Godot 4.2.
Let me know what you think of the error message.
CC: @akien-mga @YuriSizov @dsnopek