[Windows] Set application user model ID to prevent editor / running project and different versions of editor taskbar icon stacking. #85905
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
reviewed
Dec 8, 2023
| if (version.is_empty()) { | ||
| version = "0"; | ||
| } | ||
| appname = "Godot." + name.to_pascal_case() + "." + version; |
There was a problem hiding this comment.
Are there any restrictions on what the AppUserModel_ID format should be? Because application/config/name can contain all kinds of characters like punctuation, non-Latin, etc. which may not play well if not validated before passing it further.
There was a problem hiding this comment.
Added some validation, but will recheck it tomorrow to make sure it's sufficient.
akien-mga
approved these changes
Feb 15, 2024
…roject and different versions of editor taskbar icon stacking.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set application ID for the editor and project windows to prevent unnecessary taskbar icon stacking.