Stop the searching of find in files in folders that have .gdignore
#85943
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@AThousandShips i would prefer to remove the 'discussion' tag. It's a bug. |
|
I'd say it's important to discuss, the fact that the code existed might be evaluated, I'll keep it until we decide what path to take |
m4gr3d
approved these changes
Dec 21, 2023
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #85935
Fixes #79375
When a
.gdignoreis detected. It cleans everything that was in the queue to be scanned (in the current dir) and stops the scan.This is very helpful when you are developing for Android. The
Find in filesenters the res://android/build, and you get many unwanted results.Test project:
MinimalSearchInFiles.zip
Tree files of the test project:
Before (with the bug):
After (fixed):
