[WIP] Allow SDFGI, VoxelGI, ... reflections on lightmapped objects #86039

guerro323 · 2023-12-11T17:33:05Z

This complete a part of godotengine/godot-proposals#3012 (it doesn't address disabling VoxelGI reflections for SDFGI)

This add support for reflections from GI such as SDFGI onto lightmapped objects

(scene from https://sketchfab.com/3d-models/japanese-street-at-night-fb1bdcd71a5544d699379d2d13dd1171)

Simple scene:

The left part of the floor is a standard default material, the other part is a metallic with roughness set to 0.
The black cubes are material with roughness set to 0 and black color.
The grey cube is a 100% metallic white material.
The white cube is a 100% specular white material.

Lightmap Only	Lightmap + SDFGI

Benefits and constraints

It help level designers dealing with less reflection probes, especially in complex scenes (such as rounded walls, complex corridors that aren't straight, etc...)
Reflection probes can still be used (as seen in my comment in the proposal) and blends well with the GI, it's mostly useful for cube shaped interiors.
There is a cost of using Lightmapped objects + SDFGI, but it's less than SDFGI only as we only apply the reflection buffer (further optimizations could be possible).
It doesn't work well with simple shapes with no textures if you crank the roughness to 0 and metallic to 100.

TODO:

Add VoxelGI reflections
Tests to see if everything work as expected
Benchmarks¹
Screenshots comparisons¹

Open Questions:

Optimizations? It is possible to optimize SDFGI to only care about reflection data?
An option to disable this effect? Would there be an use case to only have GI reflections only on non-lightmapped objects?

¹ I posted some screenshots and benchmarks here godotengine/godot-proposals#3012 (comment). I'll make some new one for this PR.

- Set `-sSTACK_SIZE` to what it was before emscripten 3.1.27. It was renamed in 3.1.25 so also set `-sTOTAL_SIZE` for older versions for consistency. - Set `-sDEFAULT_PTHREAD_STACK_SIZE` to what it was before 3.1.30. Co-authored-by: Rémi Verschelde <rverschelde@gmail.com>

(cherry picked from commit 1dee633)

Adds query functions to get random points on navigation mesh to the NavigationServer.

…rt for system font fallback.

…rial These are needed to tweak sky exposure separately from background

…ixer When a animation track doesn't have an keys, it's possible that we leak memory due the ERR_CONTINUE_MSG macro usage. By checking the error condition first, we avoid a allocation and thus the leak.

Note: this change completely overwrites the meshoptimizer library source (from git SHA c21d3be6ddf627f8ca852ba4b6db9903b0557858) without including any patches; a distance error metric patch is still needed and will be reapplied in the next commit. The changes elsewhere are due to a signature change for meshopt_simplifyWithAttributes.

This change replicates the distance-only metric patch which is now much smaller and cleaner, as upstream simplifier already tracks distance and attribute quadrics separately - it just doesn't store both errors in the collapse structures. The old two patches were removed as they are no longer needed.

The weight is per-attribute scalar (X, Y, Z), not per-vertex; this was the case even before the library update so this appears to be an oversight.

Fixes godotengine#84530.

This provides information for the debug monitors

This is useful to speed up iteration when working on the engine (or editor). This can be combined with a script that calls `adb` to deploy the APK on a device (coupled with Godot's `--export-*` for projects) to further speed up iteration.

This also documents `physics_ticks_per_second` not being automatically adjusted, which can be important when speeding up simulation.

…ouch from mouse in input

The type of the right operand is now taken into account.

…eger and float keyframes.

- Improve behavior of SDFGI reflections combined with specular occlusion - Add an optimized method for getting reflections from VoxelGI

guerro323 · 2023-12-13T22:22:51Z

rebase failed sorry for the notifications :(

Initial work for LightmapGI + SDFGI Reflections

ae677d3

AThousandShips added enhancement topic:rendering topic:3d labels Dec 11, 2023

AThousandShips added this to the 4.x milestone Dec 11, 2023

This was referenced Dec 11, 2023

Add a cheap specular occlusion for LightmapGI godotengine/godot-proposals#8637

Open

Add Specular Occlusion to meshes under influence of LightmapGI #86102

Open

adamscott and others added 23 commits December 13, 2023 23:19

i18n: Sync translations with Weblate

7199f72

(cherry picked from commit 1dee633)

Add NavigationServer random point queries

ffc0204

Adds query functions to get random points on navigation mesh to the NavigationServer.

[Text Overrun] Add option to set custom ellipsis character, add suppo…

89688a9

…rt for system font fallback.

Rename ImportSettings dialogs to have "Dialog" in the name

0f8e5db

Expose energy_multiplier to PanoramaSkyMaterial and ProceduralSkyMate…

324370f

…rial These are needed to tweak sky exposure separately from background

Transform mesh's AABB to skeleton's space when calculate mesh's bounds.

d1125d9

Add MSAA support for WebXR

3d341f7

Added error to catch conversion on invalid image

a67e7e2

Visual shader refacter use of connection

d51671a

Replace memory allocation point of ValueTrack correctly in AnimationM…

e246ef4

…ixer When a animation track doesn't have an keys, it's possible that we leak memory due the ERR_CONTINUE_MSG macro usage. By checking the error condition first, we avoid a allocation and thus the leak.

Don't abort loading when ext_resource is missing

35e4510

SCons: Update mypy

e579e10

Remove differences of the code between old AnimationTree and Mixer

0ee95bb

Prevent overriding file info of another file when reimport creates files

74dce47

[Windows] Always use ANGLE in ARM builds.

9cfb10e

Fix theme access in the Groups editor

2676c20

Fix ColorPicker's alpha slider arrow offset

5e0e095

Fix referring to ResourceImporterScene static importers via instances

ed3c8c3

Fix dramatically overallocated normal weights

20eb449

The weight is per-attribute scalar (X, Y, Z), not per-vertex; this was the case even before the library update so this appears to be an oversight.

Update thirdparty licenses & copyright files per review

10828b5

bruvzg and others added 24 commits December 13, 2023 23:19

Force ANGLE on all pre GCN 4th gen. AMD/ATI GPUs.

63cba27

Hide Node dock successfully on undo/redo and deletion

45a7834

Fixes godotengine#84530.

Add toaster notifications for import warning.

bb2cfec

Implement render info counters for the 2D renderer

e1bc217

This provides information for the debug monitors

Change suffix from m to px

648deb7

Navigation: Fix GCC 12.3 -Wtype-limits warnings

736017a

Add WorkerThreadPool::get_thread_index()

817db3c

Add 'u' format modifier for unsigned int/hex

d8add6d

Add Direct3D 12 RenderingDevice implementation

fc15185

Fix creating and updating plugin with dot in folder name

8fba84a

fix next_ogg_packet never returning false

a076c28

Fix radiance for sky in GLES stereo rendering

93d27f6

Prevent crash when call set_text() on a removed treeItem

3377eff

Document AudioServer.playback_speed_scale in Engine.time_scale

7894dea

This also documents `physics_ticks_per_second` not being automatically adjusted, which can be important when speeding up simulation.

Add bindings for setting and getting emulation mouse from touch and t…

0e7576d

…ouch from mouse in input

Fix operator documentation in GDExtension API dump with docs

c834f6d

The type of the right operand is now taken into account.

[D3D12] Add missing DLL architecture paths for the 32-bit builds.

02e33c4

Restored the ability for linear interpolation to work on a mix of int…

fe9009e

…eger and float keyframes.

Fix regression when autocompleting subscript on get node

42790f8

first version of specular occlusion

9544440

Support for Mobile Foward and enum rename

8e6f0e0

Compatibility Support

d2e85db

Add VoxelGI reflections for LightmapGI

5b39e26

- Improve behavior of SDFGI reflections combined with specular occlusion - Add an optimized method for getting reflections from VoxelGI

guerro323 closed this Dec 13, 2023

guerro323 deleted the lightmap-gi-reflection branch December 13, 2023 22:37

Calinou added the archived label Dec 14, 2023

AThousandShips removed this from the 4.x milestone Dec 14, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[WIP] Allow SDFGI, VoxelGI, ... reflections on lightmapped objects #86039

[WIP] Allow SDFGI, VoxelGI, ... reflections on lightmapped objects #86039

guerro323 commented Dec 11, 2023

guerro323 commented Dec 13, 2023 •

edited

Loading

[WIP] Allow SDFGI, VoxelGI, ... reflections on lightmapped objects #86039

[WIP] Allow SDFGI, VoxelGI, ... reflections on lightmapped objects #86039

Conversation

guerro323 commented Dec 11, 2023

Simple scene:

Benefits and constraints

TODO:

Open Questions:

guerro323 commented Dec 13, 2023 • edited Loading

guerro323 commented Dec 13, 2023 •

edited

Loading