Disable Add button when theme item name is empty #86044
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YuriSizov
approved these changes
Dec 18, 2023
| @@ -2850,6 +2853,11 @@ void ThemeTypeEditor::_add_default_type_items() { | |||
| ur->commit_action(); | |||
| } | |||
|
|
|||
| void ThemeTypeEditor::_update_add_button(const String &p_text, LineEdit *p_for_edit) { | |||
| Button *button = Object::cast_to<Button>(p_for_edit->get_meta("button")); | |||
| button->set_disabled(p_text.strip_edges().is_empty()); | |||
There was a problem hiding this comment.
Since this logic of strip_edges().is_empty() is used relatively often it makes me wonder if it'd be worth it to add a convenience function that just checks if a string is non-empty after that operation, in this case if it has any codepoints > 32, will see about it later
AThousandShips
approved these changes
Dec 18, 2023
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Theme editor has Add button that does nothing if name is empty. This PR disables it when not available.
godot.windows.editor.dev.x86_64_Jy8wt5m37x.mp4