[TextServer] Do not draw non-visual characters. #86065
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bruvzg
force-pushed
the
non_vis_no_draw
branch
from
538fbed to
575e120
Compare
Calinou
approved these changes
Dec 12, 2023
There was a problem hiding this comment.
Tested locally, it works as expected with both Label and Label3D. This text with 36 visible characters results in 36 draw calls in Forward+/Mobile:
Test Test Test
Test Test Test
TestTestTest
Test Test Test in master results in 60 primitives in Label3D with the default settings (which includes a font outline), and 48 with this PR.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds some checks to skip drawing non-visual glyphs and glyphs with zero size texture.
See #85811 (review)