Fix operator documentation in GDExtension API dump with docs #86087
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The type of the right operand is now taken into account.
akien-mga
approved these changes
Dec 12, 2023
akien-mga
added
the
cherrypick:4.2
|
Thanks! |
YuriSizov
removed
the
cherrypick:4.2
|
Cherry-picked for 4.2.2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the bug where some binary operators had a
descriptionwhich was actually from a different binary operator with the same name but a different right operand type. Now we check the right operand type when searching for the docs of binary operators.In particular, this also removes the
descriptionfrom some (intentionally) undocumented operators like==and!=where the right operand is aVariant, and%where the left operand isStringand the right operand is not aVariant.