Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GDScript: Fix POT generator skips some nodes #86091

Merged
merged 1 commit into from
Dec 19, 2023
Merged

GDScript: Fix POT generator skips some nodes #86091

merged 1 commit into from
Dec 19, 2023

Conversation

dalexeev
Copy link
Member

@dalexeev dalexeev added this to the 4.3 milestone Dec 12, 2023
@dalexeev dalexeev requested a review from a team as a code owner December 12, 2023 21:20
@dalexeev dalexeev force-pushed the gds-fix-pot-gen-skips-some-nodes branch from 9da67ec to 455e373 Compare December 12, 2023 21:50
@akien-mga akien-mga added the cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release label Dec 12, 2023
@dalexeev dalexeev force-pushed the gds-fix-pot-gen-skips-some-nodes branch from 455e373 to 1aa242f Compare December 13, 2023 10:07
vnen
vnen approved these changes Dec 19, 2023
View reviewed changes
Copy link
Member

@vnen vnen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

adamscott
adamscott approved these changes Dec 19, 2023
View reviewed changes
Copy link
Member

@adamscott adamscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for me too!

@YuriSizov YuriSizov merged commit fc082dd into godotengine:master Dec 19, 2023
15 checks passed
@YuriSizov
Copy link
Contributor

Thanks!

@dalexeev dalexeev deleted the gds-fix-pot-gen-skips-some-nodes branch December 19, 2023 21:02
@dalexeev dalexeev mentioned this pull request Dec 23, 2023
Merged
@YuriSizov YuriSizov removed the cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release label Jan 25, 2024
@YuriSizov
Copy link
Contributor

Cherry-picked for 4.2.2.

@dalexeev dalexeev mentioned this pull request Feb 13, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamscott adamscott adamscott approved these changes

@vnen vnen vnen approved these changes

Assignees
No one assigned
Labels
bug topic:editor topic:gdscript
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.

POT generation ignores subscripts
5 participants
@dalexeev @YuriSizov @adamscott @vnen @akien-mga