-
-
Notifications
You must be signed in to change notification settings - Fork 21.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve visualization of WorldBoundary2D editor #86208
Conversation
234e9f5
to
b5f3fc0
Compare
b5f3fc0
to
3295061
Compare
I think, from the point of view of a green hand, it's not clear yet which side will be detected and which one not. Also, black is not attention-attractive and may be blended in some situations, especially when a developer is building a scene with darkness. |
You know, the blue translucent. |
3295061
to
63ff003
Compare
CollisionShape2D with |
63ff003
to
504b9a7
Compare
How would I move forward with this? |
You can join the developer chat to ask for feedback and discuss. |
@KoBeWi what do you think of this? I feel like it works quite well |
504b9a7
to
3b95954
Compare
I like this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The arrow could be bigger, but otherwise looks fine IMO.
3b95954
to
f7c9a5c
Compare
f7c9a5c
to
11c13a7
Compare
Wobblyness is likely you being project with some sort of pixel snap? Pixel snap also affects debug drawing in the editor. |
11c13a7
to
8bed36e
Compare
@Calinou what do you think of the current version of this pr? Would be nice to get it merged soon. |
Thanks! |
Fixes godotengine/godot-proposals#817
Changes the worldboundary 2d shape editor to be more clear. Changes the normal to not be the same colour as the line as it isn't actually part of the collision shape. Also changes the visualisation of the line to be a gradient to visualise that it's an infinite line.
Old
New
Let me know what you think 😄