Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[iOS export] Improve .xcframework exporting. #86288

Merged
merged 1 commit into from
Jan 15, 2024
Merged

[iOS export] Improve .xcframework exporting. #86288

merged 1 commit into from
Jan 15, 2024

Conversation

bruvzg
Copy link
Member

@bruvzg bruvzg commented Dec 18, 2023 •
edited
Loading

  • Do not embed static .xcframeworks.
  • Automatically convert .xcframeworks with .dylibs to .xcframeworks with .frameworks.

Fixes #86224
Supersede #85297

@bruvzg bruvzg added this to the 4.3 milestone Dec 18, 2023
@bruvzg bruvzg marked this pull request as ready for review December 26, 2023 21:32
@bruvzg bruvzg requested review from a team as code owners December 26, 2023 21:32
@bruvzg
[iOS export] Improve .xcframework exporting.
9efd83f 
Do not embed static .xcframeworks.
Automatically convert .xcframeworks with .dylibs to .xcframeworks with .frameworks.
@akien-mga akien-mga changed the title [iOS export] Improve .xcframework exporting. [iOS export] Improve .xcframework exporting. Jan 11, 2024
@akien-mga akien-mga mentioned this pull request Jan 11, 2024
Closed
@sassanh
Copy link
Contributor

sassanh commented Jan 13, 2024

I tested this and it worked for my app, after checking out this branch and exporting and distributing, I didn't get this error anymore:

ITMS-90426: Invalid Swift Support - The SwiftSupport folder is missing. Rebuild your app using the current public (GM) version of Xcode and resubmit it.

and instead of this file

Payload/app.app/Frameworks/app.dylib

I got these files in the ipa:

Payload/app.app/Frameworks/app.framework/_CodeSignature/CodeResources
Payload/app.app/Frameworks/app.framework/app
Payload/app.app/Frameworks/app.framework/Info.plist

@akien-mga akien-mga merged commit 0e0fa99 into godotengine:master Jan 15, 2024
15 checks passed
@akien-mga
Copy link
Member

Thanks!

@LeonardoDemartino
Copy link
Contributor

Awesome! :D

This was referenced May 29, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
bug platform:ios topic:export
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.

Error ITMS-90426 when uploading to Apple TestFlight with Godot 4.2/4.2.1
4 participants
@bruvzg @sassanh @akien-mga @LeonardoDemartino