Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove pointer to deprecated class page from Skeleton3D #86326

Merged
merged 1 commit into from
Dec 20, 2023

Conversation

MichaelMacha
Copy link
Contributor

SkeletonIK3D is now deprecated, but Skeleton3D is recommending looking into its use for complicated inverse kinematics. What's worse, the removed line is not perfectly clear for non-developers and people less experienced with the engine, and could still stand to be improved.

SkeletonIK3D is now deprecated, but Skeleton3D is recommending looking into its use for complicated inverse kinematics. What's worse, the removed line is not perfectly clear for non-developers and people less experienced with the engine, and could still stand to be improved.
@MichaelMacha MichaelMacha requested a review from a team as a code owner December 19, 2023 11:46
@AThousandShips AThousandShips added this to the 4.x milestone Dec 19, 2023
@AThousandShips AThousandShips requested a review from a team December 19, 2023 11:47
Copy link
Member

@fire fire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is accurate.

@fire fire requested a review from a team December 19, 2023 21:05
@AThousandShips AThousandShips added enhancement cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release and removed discussion labels Dec 19, 2023
@AThousandShips AThousandShips modified the milestones: 4.x, 4.3 Dec 19, 2023
@YuriSizov YuriSizov changed the title Remove pointer to deprecated class page, from Skeleton3D Remove pointer to deprecated class page from Skeleton3D Dec 20, 2023
@YuriSizov YuriSizov merged commit ed5a54d into godotengine:master Dec 20, 2023
15 checks passed
@YuriSizov
Copy link
Contributor

Thanks, and congrats on your first merged Godot contribution!

@YuriSizov YuriSizov removed the cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release label Jan 24, 2024
@YuriSizov
Copy link
Contributor

Cherry-picked for 4.2.2.

@YuriSizov YuriSizov removed the cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release label Jan 24, 2024
@YuriSizov
Copy link
Contributor

Cherry-picked for 4.1.4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants